Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: automate locations - modified API responses #661

Merged
merged 13 commits into from
Aug 13, 2024
Merged

feat: automate locations - modified API responses #661

merged 13 commits into from
Aug 13, 2024

Conversation

cka-y
Copy link
Contributor

@cka-y cka-y commented Aug 7, 2024

Summary:

This PR updates the feed endpoints and the search endpoint to use the extracted locations and includes a new country field for each location within the gtfs_feeds response.

Out of Scope:

Expected Behavior:

  • Each location in the response now includes a country field.
  • All location fields are provided in English.

Testing Tips:

  1. Access the UI link provided in the PR comments.
  2. Navigate through the feeds.
  3. Inspect the network tab response to verify the presence of the country field.
  4. Ensure that all location fields are in English.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

Copy link

github-actions bot commented Aug 7, 2024

Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-661-kn0s0x6q.web.app

@cka-y cka-y changed the title feat: added location tr to gtfs_feeds feat: automate locations - modified API GTFS feeds response Aug 7, 2024
@cka-y cka-y linked an issue Aug 7, 2024 that may be closed by this pull request
@cka-y cka-y linked an issue Aug 7, 2024 that may be closed by this pull request
@cka-y cka-y marked this pull request as ready for review August 7, 2024 19:02
@cka-y
Copy link
Contributor Author

cka-y commented Aug 7, 2024

The integration tests are expected to fail as i have introduced a new view that is not in QA yet

@cka-y cka-y linked an issue Aug 9, 2024 that may be closed by this pull request
@cka-y cka-y changed the title feat: automate locations - modified API GTFS feeds response feat: automate locations - modified API responses Aug 9, 2024
@davidgamez
Copy link
Member

Let's ignore/comment on the integration test to avoid data updates in PROD.

api/src/feeds/impl/feeds_api_impl.py Outdated Show resolved Hide resolved
liquibase/changes/feat_622.sql Outdated Show resolved Hide resolved
docs/DatabaseCatalogAPI.yaml Outdated Show resolved Hide resolved
@cka-y cka-y requested a review from davidgamez August 13, 2024 14:27
@cka-y
Copy link
Contributor Author

cka-y commented Aug 13, 2024

Let's ignore/comment on the integration test to avoid data updates in PROD.

@davidgamez The integration tests that might cause issues post merge are already commented

Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@cka-y cka-y merged commit daeef88 into main Aug 13, 2024
5 of 6 checks passed
@cka-y cka-y deleted the feat/622 branch August 13, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants