-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: automate locations - modified API responses #661
Conversation
Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-661-kn0s0x6q.web.app |
The integration tests are expected to fail as i have introduced a new view that is not in QA yet |
Let's ignore/comment on the integration test to avoid data updates in PROD. |
@davidgamez The integration tests that might cause issues post merge are already commented |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
Summary:
This PR updates the feed endpoints and the search endpoint to use the extracted locations and includes a new
country
field for each location within thegtfs_feeds
response.Out of Scope:
Expected Behavior:
country
field.Testing Tips:
country
field.Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.sh
to make sure you didn't break anything